New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add labelSelector style to filter all generators #9312
feat: Add labelSelector style to filter all generators #9312
Conversation
Fixes argoproj/applicationset#361 Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
…ilter-forgenerator-linted Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Codecov Report
@@ Coverage Diff @@
## master #9312 +/- ##
==========================================
+ Coverage 45.90% 45.91% +0.01%
==========================================
Files 222 222
Lines 26461 26473 +12
==========================================
+ Hits 12146 12156 +10
- Misses 12658 12659 +1
- Partials 1657 1658 +1
Continue to review full report at Codecov.
|
@crenshaw-dev : should there be a e2e test for this? |
@rishabh625 that's probably best. Will add one. |
@rishabh625 would you feel terribly uncomfortable with this being merged without an e2e test? Time is tight, not sure I can get that written soon. |
Please merge it , may be we'll add in some other PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crenshaw-dev The PR LGTM!
I would suggest, let's make a note somewhere to add an e2e test for this. Else there are chances that it might be forgotten.
@ishitasequeira created an issue to track it. Thanks! #9430 |
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Fixes argoproj/applicationset#361 Signed-off-by: Jan Jansen <jan.jansen@gdata.de> Co-authored-by: Jan Jansen <jan.jansen@gdata.de>
Fixes argoproj/applicationset#361
Signed-off-by: Jan Jansen jan.jansen@gdata.de
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: