Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add labelSelector style to filter all generators #9312

Conversation

crenshaw-dev
Copy link
Collaborator

Fixes argoproj/applicationset#361

Signed-off-by: Jan Jansen jan.jansen@gdata.de

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

farodin91 and others added 2 commits April 4, 2022 14:39
Fixes argoproj/applicationset#361

Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
…ilter-forgenerator-linted

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #9312 (cb22f11) into master (8a1d9fe) will increase coverage by 0.01%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #9312      +/-   ##
==========================================
+ Coverage   45.90%   45.91%   +0.01%     
==========================================
  Files         222      222              
  Lines       26461    26473      +12     
==========================================
+ Hits        12146    12156      +10     
- Misses      12658    12659       +1     
- Partials     1657     1658       +1     
Impacted Files Coverage Δ
...is/applicationset/v1alpha1/applicationset_types.go 34.69% <ø> (ø)
...licationset/generators/generator_spec_processor.go 55.71% <83.33%> (+4.04%) ⬆️
applicationset/generators/matrix.go 72.97% <100.00%> (+0.37%) ⬆️
applicationset/generators/merge.go 61.00% <100.00%> (+0.39%) ⬆️
util/settings/settings.go 48.16% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a1d9fe...cb22f11. Read the comment docs.

@rishabh625
Copy link
Contributor

@crenshaw-dev : should there be a e2e test for this?

@crenshaw-dev
Copy link
Collaborator Author

@rishabh625 that's probably best. Will add one.

@crenshaw-dev
Copy link
Collaborator Author

@rishabh625 would you feel terribly uncomfortable with this being merged without an e2e test? Time is tight, not sure I can get that written soon.

@rishabh625
Copy link
Contributor

Please merge it , may be we'll add in some other PRs

Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crenshaw-dev The PR LGTM!

I would suggest, let's make a note somewhere to add an e2e test for this. Else there are chances that it might be forgotten.

@crenshaw-dev
Copy link
Collaborator Author

@ishitasequeira created an issue to track it. Thanks! #9430

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev crenshaw-dev merged commit 0064fa7 into argoproj:master Aug 3, 2022
@crenshaw-dev crenshaw-dev deleted the add-labelselector-filter-forgenerator-linted branch August 3, 2022 19:30
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Aug 11, 2022
Fixes argoproj/applicationset#361

Signed-off-by: Jan Jansen <jan.jansen@gdata.de>

Co-authored-by: Jan Jansen <jan.jansen@gdata.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to filter each generator by a selector like a labelSelector
5 participants