New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Set GITHUB_TOKEN in the test container #9317
chore: Set GITHUB_TOKEN in the test container #9317
Conversation
Signed-off-by: jannfis <jann@mistrust.net>
@jannfis: working on removing calls to external git provider so token will not be needed for UT, but yeah for E2E requires but that is fetched from secrets |
Not sure for E2E |
@rishabh625 This is for running the tests locally, not on the CI :) |
Codecov Report
@@ Coverage Diff @@
## master #9317 +/- ##
==========================================
- Coverage 46.06% 46.04% -0.02%
==========================================
Files 217 217
Lines 25912 25912
==========================================
- Hits 11936 11931 -5
- Misses 12319 12323 +4
- Partials 1657 1658 +1
Continue to review full report at Codecov.
|
@jannfis I was under the impression that a GITHUB_TOKEN was only auto-generated during the run of a workflow only. Would a end user have to use a PAT? Let me know if I'm missing something |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think u need to set variable to run test locally else test skips, take a look at pull request generator test so it's good to have this var |
The ApplicationSet end-to-end tests need to have
GITHUB_TOKEN
set, so that the tests do not run into the unauthenticated rate limiting of GitHub.Note
GITHUB_TOKEN
needs to be properly exported in the env.Signed-off-by: jannfis jann@mistrust.net
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: