New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: combine form repo settings page #9167 #9374
Conversation
22466b6
to
993594a
Compare
Codecov Report
@@ Coverage Diff @@
## master #9374 +/- ##
==========================================
- Coverage 46.19% 45.83% -0.37%
==========================================
Files 218 222 +4
Lines 25917 26405 +488
==========================================
+ Hits 11972 12102 +130
- Misses 12290 12652 +362
+ Partials 1655 1651 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great to me! Only left a few small comments. Well done 👍
993594a
to
eeb8dd7
Compare
c080dc9
to
ff99ff6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For this PR, test all three connection types and click on the Connect button with the initial form unchanged. |
2b4026d
to
ee342d1
Compare
Signed-off-by: Regina Scott <rescott@redhat.com>
ee342d1
to
9fa7e50
Compare
Signed-off-by: Regina Scott <rescott@redhat.com>
LGTM |
Hi @rbreeze , as an FYI, we've spent some cycles reviewing and testing this, so we'd like to merge this today. If you see something we've missed, we can address them in a separate PR. |
Closes #9167
Checklist:
This PR will combine the three different methods of connecting repos into one sliding panel with a dropdown to select the connection method.
Video demonstrating new UX flow with HTTPS as an example:
repoSettingsRedesign1.mp4