Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix PR generators list #9387

Merged
merged 3 commits into from May 24, 2022
Merged

docs: fix PR generators list #9387

merged 3 commits into from May 24, 2022

Conversation

crenshaw-dev
Copy link
Collaborator

@crenshaw-dev crenshaw-dev commented May 12, 2022 •
edited

We don't actually support GitLab yet (but we will in 2.5 thanks to #9264).

@crenshaw-dev
docs: fix PR generators list
c0d21df 
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev crenshaw-dev added the cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch label May 12, 2022
@codecov
Copy link

codecov bot commented May 12, 2022 •
edited

Codecov Report

Merging #9387 (423743b) into master (725b2d4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9387   +/-   ##
=======================================
  Coverage   45.70%   45.70%           
=======================================
  Files         221      221           
  Lines       26293    26293           
=======================================
  Hits        12018    12018           
  Misses      12615    12615           
  Partials     1660     1660
Impacted Files Coverage Δ
util/settings/settings.go 48.16% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b289b...423743b. Read the comment docs.

ishitasequeira
ishitasequeira approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crenshaw-dev crenshaw-dev requested a review from leoluz May 20, 2022 13:30
@crenshaw-dev
grammar
9893ba0 
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) May 20, 2022 15:14
@crenshaw-dev crenshaw-dev merged commit 9346e19 into argoproj:master May 24, 2022
@crenshaw-dev crenshaw-dev deleted the fix-pr-generator-list branch May 31, 2022 16:03
crenshaw-dev added a commit that referenced this pull request May 31, 2022
@crenshaw-dev
docs: fix PR generators list (#9387)
0d10927 
* docs: fix PR generators list

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* grammar

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@syed-zizou
Copy link

When will we have v2.5 released?

@leoluz
Copy link
Collaborator

leoluz commented Jun 6, 2022

@syed-zizou you can track the release plan by the milestone:
https://github.com/argoproj/argo-cd/milestone/26
Note that this is not a fixed date. Just a rough prediction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoluz leoluz leoluz approved these changes

@alexmt alexmt alexmt approved these changes

@ishitasequeira ishitasequeira ishitasequeira approved these changes

Assignees
No one assigned
Labels
cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@crenshaw-dev @syed-zizou @leoluz @alexmt @ishitasequeira