New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Slugified the branch name in PR generators #9462
feat: Slugified the branch name in PR generators #9462
Conversation
527fb03
to
46ca395
Compare
Codecov Report
@@ Coverage Diff @@
## master #9462 +/- ##
==========================================
- Coverage 45.86% 45.84% -0.03%
==========================================
Files 221 222 +1
Lines 26309 26409 +100
==========================================
+ Hits 12067 12106 +39
- Misses 12586 12652 +66
+ Partials 1656 1651 -5
Continue to review full report at Codecov.
|
87a5d95
to
c7883fe
Compare
@Aym3nTN thanks for the PR! Instead of changing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+branchSlug
I agree with you.. I'd suggest also making |
e3734d8
to
4e9c942
Compare
@Aym3nTN instead of introducing a new config field that toggles the |
Add branchSlug attr to not cause a breaking change Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@cimpress.com>
Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@cimpress.com>
Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@cimpress.com>
4e9c942
to
ad078bc
Compare
Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@cimpress.com>
@crenshaw-dev I totally agree with you on; and also it's less risky that way.. keeping the old |
Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@cimpress.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Aym3nTN!
* Slugified the branch name in PR generators Add branchSlug attr to not cause a breaking change Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@cimpress.com> * Fixed pull_request_test Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@cimpress.com> * Adding 'branch_slug' as an output of the generator Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@cimpress.com> * Updated the doc Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@cimpress.com> * Fixed test Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@cimpress.com> Co-authored-by: Aymen Ben Tanfous <aymen.bentanfous@cimpress.com>
Enhancement proposal/Fix: #9461
Fixes #9461
Checklist: