Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add argocd binary to argocd-test-tool docker image (#9459) #9467

Merged
merged 1 commit into from May 24, 2022

Conversation

cippaciong
Copy link
Contributor

Fixes #9459

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #9467 (2285066) into master (ba7d2e7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9467   +/-   ##
=======================================
  Coverage   45.71%   45.71%           
=======================================
  Files         221      221           
  Lines       26289    26289           
=======================================
  Hits        12019    12019           
  Misses      12610    12610           
  Partials     1660     1660           
Impacted Files Coverage Δ
util/settings/settings.go 48.16% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba7d2e7...2285066. Read the comment docs.

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment in #9459

@cippaciong cippaciong force-pushed the chore/argocd-test-tools-binary branch from ead5629 to 3bd3adf Compare May 23, 2022 09:30
)

Signed-off-by: Tommaso Sardelli <lacapannadelloziotom@gmail.com>
@cippaciong cippaciong force-pushed the chore/argocd-test-tools-binary branch from 3bd3adf to 2285066 Compare May 23, 2022 09:31
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jannfis jannfis merged commit 725b2d4 into argoproj:master May 24, 2022
@cippaciong cippaciong deleted the chore/argocd-test-tools-binary branch May 25, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing argocd binary from argocd-test-tools docker image
2 participants