Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump helm version to 3.9.0 #9486

Merged
merged 1 commit into from May 27, 2022

Conversation

carbohydrates
Copy link
Contributor

@carbohydrates carbohydrates commented May 23, 2022

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Yevhen Sakhniuk <yevhens@backbase.com>
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #9486 (3825623) into master (ba7d2e7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9486   +/-   ##
=======================================
  Coverage   45.71%   45.71%           
=======================================
  Files         221      221           
  Lines       26289    26289           
=======================================
  Hits        12019    12019           
  Misses      12610    12610           
  Partials     1660     1660           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba7d2e7...3825623. Read the comment docs.

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I see some thumbs-up. Does this need to be cherry-picked to 2.4?

@trigger305
Copy link

please add to 2.4 - the merge in helm 3.9.0 has some improvements in it

@crenshaw-dev
Copy link
Collaborator

@jannfis @alexmt any opposition to cherry-picking?

@crenshaw-dev
Copy link
Collaborator

If we do cherry-pick, we should add a note to https://github.com/argoproj/argo-cd/blob/master/docs/operator-manual/upgrading/2.3-2.4.md

@jannfis
Copy link
Member

jannfis commented May 27, 2022

I'm not very fond of bumping a minor tool version after 2 RCs have been out already, unless there's a very good reason.

@crenshaw-dev
Copy link
Collaborator

I'm going to merge so this PR doesn't sit. @trigger305 if you feel very strongly, can you open an issue making the case for cherry-picking and then link it here?

@crenshaw-dev crenshaw-dev merged commit c4306da into argoproj:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants