fix: upgrade superagent to resolve potential CVE

[alexmt]

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

PR upgrades superagent to resolve https://security.snyk.io/vuln/SNYK-JS-FORMIDABLE-2838956

Additionally removes no longer required superagent-promise and @types/superagent packages

[crenshaw-dev]

Nice. Want to go ahead and remove the ignore rule in .snyk? That'd let us catch if a future change re-introduces the vulnerability.

snyk test --org=argoproj --all-projects --exclude=docs,site --policy-path=.snyk --severity-threshold=high to make sure the change removed all vulnerable paths.

[crenshaw-dev]

Oh lol this was never merged #9470

Closing in favor of this one.

[alexmt]

Thanks for noticing @crenshaw-dev !

[alexmt]

Ops, had to re-add @types/superagent - it is still required. @crenshaw-dev can you please take a look one more time.

[codecov]

Codecov Report

Merging #9494 (cdeae5d) into master (1b6275a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9494   +/-   ##
=======================================
  Coverage   45.71%   45.71%           
=======================================
  Files         221      221           
  Lines       26289    26289           
=======================================
  Hits        12019    12019           
  Misses      12610    12610           
  Partials     1660     1660           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b6275a...cdeae5d. Read the comment docs.

[rbreeze]

LGTM!

[crenshaw-dev]

Cherry-picked onto release-2.4 to simplify cherry-pick of #11743