Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add GOPKGINYAMLV2-2840885 to snyk ignore list #9495

Merged
merged 1 commit into from May 23, 2022

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented May 23, 2022

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

The CVE reported in https://security.snyk.io/vuln/SNYK-GOLANG-GOPKGINYAMLV2-2840885 is not applicable to Argo CD since the affected package is used to parse admin provided configuration. Admins already have full access to Argo CD so DoS is not a treat here.

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@alexmt alexmt requested a review from crenshaw-dev May 23, 2022 21:29
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #9495 (698b1cd) into master (1b6275a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9495   +/-   ##
=======================================
  Coverage   45.71%   45.71%           
=======================================
  Files         221      221           
  Lines       26289    26289           
=======================================
  Hits        12019    12019           
  Misses      12610    12610           
  Partials     1660     1660           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b6275a...698b1cd. Read the comment docs.

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@alexmt alexmt enabled auto-merge (squash) May 23, 2022 22:04
@alexmt alexmt merged commit 9b3d277 into argoproj:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants