Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove temp directories from repo server tests #9501

Merged
merged 1 commit into from
May 24, 2022

Conversation

jannfis
Copy link
Member

@jannfis jannfis commented May 24, 2022

Removes temp directories, so they don't interfere with consecutive test runs.

Also, some minor corrections by gofmt.

Signed-off-by: jannfis jann@mistrust.net

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: jannfis <jann@mistrust.net>
@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #9501 (145076b) into master (725b2d4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9501   +/-   ##
=======================================
  Coverage   45.70%   45.70%           
=======================================
  Files         221      221           
  Lines       26293    26293           
=======================================
  Hits        12018    12018           
  Misses      12615    12615           
  Partials     1660     1660           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 725b2d4...145076b. Read the comment docs.

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jannfis jannfis merged commit 26b289b into argoproj:master May 24, 2022
@crenshaw-dev crenshaw-dev added the cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch label Jun 13, 2022
crenshaw-dev pushed a commit that referenced this pull request Jun 13, 2022
Signed-off-by: jannfis <jann@mistrust.net>
@crenshaw-dev
Copy link
Collaborator

Cherry-picked onto 2.4 because it was bothering me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants