fix: better error message for invalid repo URL #9513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Codecov Report
@@ Coverage Diff @@
## master #9513 +/- ##
==========================================
+ Coverage 45.86% 45.88% +0.01%
==========================================
Files 221 221
Lines 26309 26312 +3
==========================================
+ Hits 12067 12072 +5
+ Misses 12586 12585 -1
+ Partials 1656 1655 -1
Continue to review full report at Codecov.
|
|
There seems to be a conflict. |
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now a bad repo URL gives a weird error message about the temp directory root being the same as the repo root.
This change throws a better error message that explains why the hypothetical repo root would be the same as /tmp - because URL validation failed and the validator returned an empty string.
Opened because of this question: https://cloud-native.slack.com/archives/C01TSERG0KZ/p1653498323603809