Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to filter MRs by 'state' to Gitlab PR Generator #9539

Closed
Aym3nTN opened this issue May 30, 2022 · 0 comments · Fixed by #9540
Closed

Add the ability to filter MRs by 'state' to Gitlab PR Generator #9539

Aym3nTN opened this issue May 30, 2022 · 0 comments · Fixed by #9540
Labels
enhancement New feature or request

Comments

@Aym3nTN
Copy link
Contributor

Aym3nTN commented May 30, 2022

Summary

In the Gitlab PR Generators, I wanted to give the developer the ability to provide the 'state' (usually opened) of Gitlab merge requests he wants to create an ephemeral environment for.

Motivation

In the current Gitlab PR Gen, it grabs all the MRs even those with state 'closed' or 'merged'. We wanted to limit it to only 'opened' MRs so when the MRs gets closed or merged the ephemeral environment dies.

Proposal

This should be implemented by simply adding an attribute like pullRequestState to the GitlabPullRequestGenerator with the state that the developer wants to track.
This enhancement proposal is only for Gitlab PR Gen since each SCM provider has its own way to filter MRs or PRs and its own state naming style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant