Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove cache from image build #9564

Merged
merged 1 commit into from Jun 2, 2022

Conversation

34fathombelow
Copy link
Member

@34fathombelow 34fathombelow commented Jun 2, 2022

Signed-off-by: Justin Marquis 34fathombelow@protonmail.com

Remove Cache from image build, its breaking the CI
Please label with test-arm-image!!!

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #9564 (14b2fe8) into master (5edaa6c) will decrease coverage by 0.21%.
The diff coverage is 40.38%.

@@            Coverage Diff             @@
##           master    #9564      +/-   ##
==========================================
- Coverage   45.86%   45.64%   -0.22%     
==========================================
  Files         221      222       +1     
  Lines       26309    26380      +71     
==========================================
- Hits        12067    12042      -25     
- Misses      12586    12690     +104     
+ Partials     1656     1648       -8     
Impacted Files Coverage Δ
controller/appcontroller.go 52.07% <0.00%> (-0.21%) ⬇️
util/argo/managedfields/parser.go 100.00% <ø> (ø)
util/app/discovery/discovery.go 40.27% <33.33%> (ø)
util/argo/managedfields/managed_fields.go 42.04% <36.61%> (-32.96%) ⬇️
cmpserver/plugin/plugin.go 49.28% <50.00%> (+1.80%) ⬆️
controller/state.go 73.64% <50.00%> (-0.26%) ⬇️
controller/sync.go 56.84% <50.00%> (-0.12%) ⬇️
util/argo/diff/diff.go 52.20% <60.00%> (-0.07%) ⬇️
reposerver/repository/repository.go 60.44% <66.66%> (-0.97%) ⬇️
util/helm/helm.go 42.66% <0.00%> (-18.67%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f48d5...14b2fe8. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alexmt alexmt merged commit b2fe209 into argoproj:master Jun 2, 2022
@34fathombelow 34fathombelow deleted the remove-cache branch June 2, 2022 01:21
KENNYSOFT pushed a commit to KENNYSOFT/argo-cd that referenced this pull request Jul 17, 2022
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
# Conflicts:
#	.github/workflows/image.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants