Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix plugin var test for OSX #9590

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

crenshaw-dev
Copy link
Collaborator

Fixing a delightful OSX quirk.

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #9590 (428e1cb) into master (50bf41f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9590   +/-   ##
=======================================
  Coverage   45.82%   45.83%           
=======================================
  Files         222      222           
  Lines       26376    26405   +29     
=======================================
+ Hits        12087    12102   +15     
- Misses      12642    12652   +10     
- Partials     1647     1651    +4     
Impacted Files Coverage Δ
...licationset/generators/generator_spec_processor.go 51.66% <0.00%> (-5.91%) ⬇️
util/settings/settings.go 48.16% <0.00%> (ø)
applicationset/generators/matrix.go 72.60% <0.00%> (+0.38%) ⬆️
applicationset/generators/merge.go 60.60% <0.00%> (+0.40%) ⬆️
applicationset/generators/cluster.go 78.12% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50bf41f...428e1cb. Read the comment docs.

Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoluz leoluz merged commit ab1b0ec into argoproj:master Jun 8, 2022
@crenshaw-dev crenshaw-dev deleted the fix-plugin-var-test-for-osx branch June 8, 2022 17:00
@crenshaw-dev crenshaw-dev added the cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch label Jun 13, 2022
crenshaw-dev added a commit that referenced this pull request Jun 13, 2022
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev
Copy link
Collaborator Author

Cherry-picked onto 2.4 to make my local testing easier. :-P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants