Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add k8s v1.24.1 release to test matrix #9636

Merged
merged 1 commit into from Jun 13, 2022

Conversation

danielhelfand
Copy link
Contributor

Closes #9603

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #9636 (770e21e) into master (081608e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9636   +/-   ##
=======================================
  Coverage   45.81%   45.81%           
=======================================
  Files         225      225           
  Lines       26531    26531           
=======================================
  Hits        12155    12155           
  Misses      12719    12719           
  Partials     1657     1657           
Impacted Files Coverage Δ
util/settings/settings.go 48.16% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 081608e...770e21e. Read the comment docs.

@danielhelfand danielhelfand marked this pull request as ready for review June 11, 2022 18:50
@danielhelfand danielhelfand reopened this Jun 11, 2022
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@crenshaw-dev crenshaw-dev merged commit 3966e50 into argoproj:master Jun 13, 2022
@danielhelfand danielhelfand deleted the 9603 branch June 17, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Kubernetes v1.24 to CI
2 participants