Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert adding k8s 1.24.1 to test matrix #9657

Merged
merged 1 commit into from Jun 14, 2022

Conversation

danielhelfand
Copy link
Contributor

Adding 1.24.1 appears to be causing some flakey behavior for e2e tests as shown here. For now, we'll remove from test matrix and figure out how to introduce gracefully.

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
@danielhelfand danielhelfand marked this pull request as ready for review June 14, 2022 17:45
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) June 14, 2022 17:46
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #9657 (79f1d76) into master (3966e50) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9657   +/-   ##
=======================================
  Coverage   45.76%   45.76%           
=======================================
  Files         225      225           
  Lines       26565    26565           
=======================================
  Hits        12157    12157           
  Misses      12751    12751           
  Partials     1657     1657           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3966e50...79f1d76. Read the comment docs.

@crenshaw-dev crenshaw-dev merged commit a66046e into argoproj:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants