ArgoCD Dockerfile contains broken symlink (/app/config/ssh/ssh_known_hosts)

[JorenZ]

Checklist:

• I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
• I've included steps to reproduce the bug.
• I've pasted the output of argocd version.

Describe the bug

I noticed that the Dockerfile contains a broken symlink. See https://github.com/argoproj/argo-cd/blob/master/Dockerfile#L66:

• current: ln -s ssh_known_hosts /etc/ssh/ssh_known_hosts (in WORKDIR /app/config/ssh)
• proposed: ln -s /app/config/ssh/ssh_known_hosts /etc/ssh/ssh_known_hosts (in WORKDIR /app/config/ssh) instead

The current code effectively creates the symlink /etc/ssh/ssh_known_hosts > /etc/ssh/ssh_known_hosts, which does not work because it loops to itself.

To Reproduce

$ docker run --entrypoint bash --rm -it \
  argoproj/argocd:v2.4.0 \
  -c "cat /etc/ssh/ssh_known_hosts"
cat: /etc/ssh/ssh_known_hosts: Too many levels of symbolic links

Expected behavior

$ docker run --entrypoint bash --rm -it \
  argoproj/argocd:v2.4.0 \
  -c "cat /etc/ssh/ssh_known_hosts"

# no output since empty file

Screenshots

N/A

Version

argocd@b512e45c0d29:~$ argocd version
argocd: v2.4.0+91aefab
  BuildDate: 2022-06-10T17:23:37Z
  GitCommit: 91aefabc5b213a258ddcfe04b8e69bb4a2dd2566
  GitTreeState: clean
  GoVersion: go1.18.3
  Compiler: gc
  Platform: linux/amd64
FATA[0001] Argo CD server address unspecified       

Logs

N/A