feat: add support for default container annotation (#8015) #9769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Grönroos <edward@gronroos.se>
Signed-off-by: Edward Grönroos <edward@gronroos.se>
crenshaw-dev
changed the title
|
@edwardgronroos can you resolve conflicts? |
Codecov Report
@@ Coverage Diff @@
## master #9769 +/- ##
=======================================
Coverage 46.18% 46.18%
=======================================
Files 226 226
Lines 27581 27581
=======================================
Hits 12737 12737
Misses 13124 13124
Partials 1720 1720 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ashutosh16
pushed a commit
to ashutosh16/argo-cd
that referenced
this pull request
Aug 11, 2022
…rgoproj#9769) * feat: add support for default container in logs/exec Signed-off-by: Edward Grönroos <edward@gronroos.se> * chore: resolve linting issues Signed-off-by: Edward Grönroos <edward@gronroos.se>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using the (
kubectl.kubernetes.io/default-containerannotation)[https://kubernetes.io/docs/reference/labels-annotations-taints/#kubectl-kubernetes-io-default-container] on a pod, we can let developers decide default, both for argocd and kubectl.It's particularly useful if/when sidecars decide where to be injected, as mentioned in the issue linkerd recently changed to be the first starting container (linkerd/linkerd2#5967) causing UI to always open up logs on that tab.
Fixes #8015
Checklist: