Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjust docs #9829

Merged
merged 1 commit into from Jun 30, 2022
Merged

chore: adjust docs #9829

merged 1 commit into from Jun 30, 2022

Conversation

maxknee
Copy link
Contributor

@maxknee maxknee commented Jun 29, 2022

Signed-off-by: Max Knee max.knee@nytimes.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Max Knee <max.knee@nytimes.com>
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #9829 (e27c059) into master (7630d43) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9829   +/-   ##
=======================================
  Coverage   45.86%   45.86%           
=======================================
  Files         227      227           
  Lines       26861    26861           
=======================================
  Hits        12319    12319           
  Misses      12862    12862           
  Partials     1680     1680           
Impacted Files Coverage Δ
util/settings/settings.go 48.16% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7630d43...e27c059. Read the comment docs.

@jessesuen jessesuen merged commit 1717eb9 into argoproj:master Jun 30, 2022
@maxknee maxknee deleted the update-docs branch June 30, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants