Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix import of context package across codebase #9852

Merged
merged 3 commits into from Jul 1, 2022

Conversation

jannfis
Copy link
Member

@jannfis jannfis commented Jul 1, 2022

Several packages were importing context from golang.org/x/net/context, while it's been integrated into the standard library for some serious while now.

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: jannfis <jann@mistrust.net>
Signed-off-by: jannfis <jann@mistrust.net>
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #9852 (10d748a) into master (ee7356a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9852   +/-   ##
=======================================
  Coverage   45.86%   45.86%           
=======================================
  Files         227      227           
  Lines       26862    26862           
=======================================
  Hits        12320    12320           
  Misses      12862    12862           
  Partials     1680     1680           
Impacted Files Coverage Δ
server/account/account.go 69.62% <ø> (ø)
server/application/application.go 31.46% <ø> (ø)
server/cluster/cluster.go 29.95% <ø> (ø)
server/repository/repository.go 52.41% <ø> (ø)
server/server.go 53.18% <ø> (ø)
util/db/certificate.go 75.66% <ø> (ø)
util/db/cluster.go 60.00% <ø> (ø)
util/db/repository.go 39.28% <ø> (ø)
util/db/repository_legacy.go 48.87% <ø> (ø)
util/db/repository_secrets.go 69.68% <ø> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee7356a...10d748a. Read the comment docs.

Signed-off-by: jannfis <jann@mistrust.net>
Comment on lines +14 to +17
type sanitizerKey string

const (
contextKey = "sanitizer"
contextKey sanitizerKey = "sanitizer"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter complained about contextKey being of type string, so I wrapped it in its own type.

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@crenshaw-dev crenshaw-dev merged commit c1d8173 into argoproj:master Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants