test: Remove circular symlinks from testdata #9886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jannfis <jann@mistrust.net>
Signed-off-by: jannfis <jann@mistrust.net>
Signed-off-by: jannfis <jann@mistrust.net>
Codecov Report
@@ Coverage Diff @@
## master #9886 +/- ##
=======================================
Coverage 45.73% 45.73%
=======================================
Files 227 227
Lines 26953 26953
=======================================
Hits 12327 12327
Misses 12946 12946
Partials 1680 1680 Continue to review full report at Codecov.
|
Signed-off-by: jannfis <jann@mistrust.net>
crenshaw-dev
approved these changes
Jul 6, 2022
| return err | ||
| } | ||
| defer func() { | ||
| if err := os.Chdir(oldWorkingDir); err != nil { |
There was a problem hiding this comment.
Is it possible we're gonna run into race conditions when other tests assume a certain working directory?
jannfis
added
the
cherry-pick/2.4
|
Cherry-picking this into release-2.4 |
jannfis
added a commit
that referenced
this pull request
Jul 6, 2022
* test: Remove circular symlinks from testdata Signed-off-by: jannfis <jann@mistrust.net> * Another test case Signed-off-by: jannfis <jann@mistrust.net> * Use defer for changing back to original workdir Signed-off-by: jannfis <jann@mistrust.net> * Abort the test on error in defer Signed-off-by: jannfis <jann@mistrust.net>
jannfis
added a commit
that referenced
this pull request
Jul 28, 2022
* test: Remove circular symlinks from testdata Signed-off-by: jannfis <jann@mistrust.net> * Another test case Signed-off-by: jannfis <jann@mistrust.net> * Use defer for changing back to original workdir Signed-off-by: jannfis <jann@mistrust.net> * Abort the test on error in defer Signed-off-by: jannfis <jann@mistrust.net>
jannfis
added a commit
that referenced
this pull request
Jul 28, 2022
* test: Remove circular symlinks from testdata Signed-off-by: jannfis <jann@mistrust.net> * Another test case Signed-off-by: jannfis <jann@mistrust.net> * Use defer for changing back to original workdir Signed-off-by: jannfis <jann@mistrust.net> * Abort the test on error in defer Signed-off-by: jannfis <jann@mistrust.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes circular symlinks from testdata of repo server, and instead creates the links at runtime during the tests.
This fixes build breakage on certain infrastructures.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: