New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: validateProject() function in app_project_types.go file has nil dereference bug (#9914) #9917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CoderTH! Could you maybe modify one of the existing ValidateProject
tests to cover this?
Codecov Report
@@ Coverage Diff @@
## master #9917 +/- ##
==========================================
- Coverage 45.82% 45.79% -0.03%
==========================================
Files 227 227
Lines 27005 27029 +24
==========================================
+ Hits 12375 12378 +3
- Misses 12941 12959 +18
- Partials 1689 1692 +3
Continue to review full report at Codecov.
|
Of course, I would be happy to do that. I have completed the test for this piece, please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Can you check the details of the failed DCO check for instructions to fix it?
…dereference bug fix: validateProject() function in app_project_types.go file has nil dereference bug Signed-off-by: hai.tang <hai.tang@daocloud.io>
Head branch was pushed to by a user without write access
3a512cb
to
ffd6585
Compare
Fixd. can you help me merge? |
@CoderTH thanks! I'll enable auto-merge so it'll be merged when the checks pass. |
LGTM!!! |
fixd #9914
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: