Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validateProject() function in app_project_types.go file has nil dereference bug (#9914) #9917

Merged
merged 1 commit into from Jul 8, 2022

Conversation

CoderTH
Copy link
Contributor

@CoderTH CoderTH commented Jul 8, 2022

fixd #9914

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CoderTH! Could you maybe modify one of the existing ValidateProject tests to cover this?

@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #9917 (ffd6585) into master (335ffa8) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #9917      +/-   ##
==========================================
- Coverage   45.82%   45.79%   -0.03%     
==========================================
  Files         227      227              
  Lines       27005    27029      +24     
==========================================
+ Hits        12375    12378       +3     
- Misses      12941    12959      +18     
- Partials     1689     1692       +3     
Impacted Files Coverage Δ
pkg/apis/application/v1alpha1/app_project_types.go 54.40% <100.00%> (+2.57%) ⬆️
server/server.go 50.86% <0.00%> (-2.32%) ⬇️
util/settings/settings.go 48.17% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 335ffa8...ffd6585. Read the comment docs.

@CoderTH
Copy link
Contributor Author

CoderTH commented Jul 8, 2022

Thanks @CoderTH! Could you maybe modify one of the existing ValidateProject tests to cover this?

Of course, I would be happy to do that. I have completed the test for this piece, please review

@CoderTH CoderTH requested a review from crenshaw-dev July 8, 2022 19:16
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Can you check the details of the failed DCO check for instructions to fix it?

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) July 8, 2022 19:22
…dereference bug

fix: validateProject() function in app_project_types.go file has nil dereference bug
Signed-off-by: hai.tang <hai.tang@daocloud.io>
auto-merge was automatically disabled July 8, 2022 19:26

Head branch was pushed to by a user without write access

@CoderTH CoderTH force-pushed the master branch 2 times, most recently from 3a512cb to ffd6585 Compare July 8, 2022 20:24
@CoderTH
Copy link
Contributor Author

CoderTH commented Jul 8, 2022

lgtm! Can you check the details of the failed DCO check for instructions to fix it?

Fixd. can you help me merge?

@crenshaw-dev
Copy link
Collaborator

@CoderTH thanks! I'll enable auto-merge so it'll be merged when the checks pass.

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) July 8, 2022 20:31
@crenshaw-dev crenshaw-dev merged commit 10324a6 into argoproj:master Jul 8, 2022
@Varsion
Copy link

Varsion commented Jul 9, 2022

LGTM!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants