Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use install instead of curling directly to /usr/local/bin #9944

Merged
merged 1 commit into from Aug 3, 2022
Merged

docs: use install instead of curling directly to /usr/local/bin #9944

merged 1 commit into from Aug 3, 2022

Conversation

crenshaw-dev
Copy link
Collaborator

Supersedes #3463

@crenshaw-dev crenshaw-dev mentioned this pull request Jul 11, 2022
Closed
5 tasks
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #9944 (3a704b3) into master (3ee03f6) will increase coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9944      +/-   ##
==========================================
+ Coverage   45.56%   45.79%   +0.22%     
==========================================
  Files         227      227              
  Lines       27170    27043     -127     
==========================================
+ Hits        12381    12385       +4     
+ Misses      13098    12966     -132     
- Partials     1691     1692       +1
Impacted Files Coverage Δ
server/application/logs.go 82.45% <0.00%> (-3.26%) ⬇️
server/rbacpolicy/rbacpolicy.go 82.35% <0.00%> (-2.43%) ⬇️
util/settings/settings.go 48.17% <0.00%> (ø)
pkg/apiclient/grpcproxy.go 0.00% <0.00%> (ø)
pkg/apiclient/apiclient.go 1.19% <0.00%> (+0.22%) ⬆️
...is/applicationset/v1alpha1/applicationset_types.go 40.90% <0.00%> (+8.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ee03f6...3a704b3. Read the comment docs.

@ashutosh16
Copy link
Contributor

thanks, @crenshaw-dev LGTM

notfromstatefarm
notfromstatefarm approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@notfromstatefarm notfromstatefarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

jannfis
jannfis approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jannfis jannfis merged commit 94e12e6 into argoproj:master Aug 3, 2022
@crenshaw-dev crenshaw-dev deleted the install-cli-with-sudo branch August 3, 2022 19:30
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Aug 11, 2022
@crenshaw-dev
docs: use install instead of curling directly to /usr/local/bin (ar…
f298535 
…goproj#9944)

Signed-off-by: CI <michael@crenshaw.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannfis jannfis jannfis approved these changes

@notfromstatefarm notfromstatefarm notfromstatefarm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crenshaw-dev @ashutosh16 @jannfis @notfromstatefarm