Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add GLOBIS to users #9987

Merged
merged 1 commit into from Jul 15, 2022
Merged

docs: add GLOBIS to users #9987

merged 1 commit into from Jul 15, 2022

Conversation

chroju
Copy link
Contributor

@chroju chroju commented Jul 14, 2022

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: chroju <chroju@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #9987 (d494426) into master (dee67bd) will decrease coverage by 0.03%.
The diff coverage is 53.84%.

@@            Coverage Diff             @@
##           master    #9987      +/-   ##
==========================================
- Coverage   46.00%   45.96%   -0.04%     
==========================================
  Files         227      227              
  Lines       27236    27276      +40     
==========================================
+ Hits        12529    12538       +9     
- Misses      13009    13036      +27     
- Partials     1698     1702       +4     
Impacted Files Coverage Δ
util/dex/dex.go 57.14% <16.66%> (-30.74%) ⬇️
util/tls/tls.go 74.66% <23.07%> (-3.54%) ⬇️
util/dex/config.go 85.56% <50.00%> (-3.45%) ⬇️
server/server.go 51.49% <60.00%> (+0.24%) ⬆️
util/oidc/oidc.go 56.12% <100.00%> (+0.34%) ⬆️
util/session/sessionmanager.go 73.94% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1be1a04...d494426. Read the comment docs.

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chroju!

@crenshaw-dev crenshaw-dev merged commit 7df9a0b into argoproj:master Jul 15, 2022
@chroju chroju deleted the add_globis branch July 18, 2022 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants