fix: Fast fail invalid SNS notification. Fixes: #1182 (#1185)

Signed-off-by: Derek Wang <whynowy@gmail.com>
argoproj · Apr 22, 2021 · 79cae5c · 79cae5c
1 parent cff9e33
commit 79cae5c
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/eventsources/sources/awssns/start.go b/eventsources/sources/awssns/start.go
@@ -130,6 +130,11 @@ func (router *Router) HandleRoute(writer http.ResponseWriter, request *http.Requ
 		return
 	}
 
+	if notification == nil {
+		common.SendErrorResponse(writer, "bad request, not a valid SNS notification")
+		return
+	}
+
 	// SNS Signature Verification
 	if router.eventSource.ValidateSignature {
 		err = notification.verify()