Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka Trigger: cannot accept multiple brokers #1006

Closed
spaghettifunk opened this issue Jan 11, 2021 · 0 comments
Closed

Kafka Trigger: cannot accept multiple brokers #1006

spaghettifunk opened this issue Jan 11, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@spaghettifunk
Copy link
Contributor

Describe the bug
The same issue was present in the EventSource and fixed in #894 . However, the same problem appears in the Sensor code (https://github.com/argoproj/argo-events/blob/master/sensors/triggers/kafka/kafka.go#L89)

To Reproduce
Steps to reproduce the behavior:

  1. Create an EventSource to receive a message
  2. Create a Source with the KafkaTrigger
  3. Set under the url a string with multiple kafka brokers url separated by a comma
  4. Send a message
  5. See error in the sensor pod

Expected behavior
The expected behaviour should be that you can define multiple brokers URL in the url paramater separated by a comma

Environment (please complete the following information):

  • Kubernetes: v1.18.1
  • Argo: v2.13.2
  • Argo Events: v1.2.0

Additional context
The error you get in the sensor pod is the following:

{"level":"error","ts":1609935890.4802158,"logger":"argo-events.sensor","caller":"sensors/trigger.go:80","msg":"failed to invoke the trigger","sensorName":"vod-ratings-sensor","trigger":"kafka-ratings","error":"kafka: client has run out of available brokers to talk to (Is your cluster reachable?)","stacktrace":"github.com/argoproj/argo-events/sensors.(*SensorContext).GetTrigger\n\t/home/runner/work/argo-events/argo-events/sensors/trigger.go:80\ngithub.com/argoproj/argo-events/sensors.(*SensorContext).triggerActions\n\t/home/runner/work/argo-events/argo-events/sensors/listener.go:234\ngithub.com/argoproj/argo-events/sensors.(*SensorContext).ListenEvents.func1.3\n\t/home/runner/work/argo-events/argo-events/sensors/listener.go:148"}

Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@spaghettifunk spaghettifunk added the bug Something isn't working label Jan 11, 2021
juliev0 pushed a commit to juliev0/argo-events that referenced this issue Mar 29, 2022
* use split function for kafka brokers url

Signed-off-by: Davide Berdin <davideberdin@gmail.com>

* add comment for kafka brokers url

Signed-off-by: Davide Berdin <davideberdin@gmail.com>

* add rtlnl in the USERS.md file

Signed-off-by: Davide Berdin <davideberdin@gmail.com>

* ran: make codegen

Signed-off-by: Davide Berdin <davideberdin@gmail.com>

* add back namespace-install.yaml

Signed-off-by: Davide Berdin <davideberdin@gmail.com>

* add new line in namespace-install.yaml file

Signed-off-by: Davide Berdin <davideberdin@gmail.com>

* missing line

Signed-off-by: Davide Berdin <davideberdin@gmail.com>

* Update namespace-install.yaml

remove extra space

Co-authored-by: Derek Wang <whynowy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant