fix(slack trigger): properly iterate api response #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksanderGondek
force-pushed
the
issue-1057-slack-trigger-fix-api-response-pagination
branch
from
e1ba6cb
to
ebffc73
Compare
AleksanderGondek
changed the title
AleksanderGondek
changed the title
The iteration should not assume every page has size of limit set (200) Signed-off-by: Aleksander Gondek <gondekaleksander@protonmail.com>
AleksanderGondek
force-pushed
the
issue-1057-slack-trigger-fix-api-response-pagination
branch
from
ebffc73
to
ca63173
Compare
whynowy
pushed a commit
that referenced
this pull request
Feb 18, 2021
The iteration should not assume every page has size of limit set (200) Signed-off-by: Aleksander Gondek <gondekaleksander@protonmail.com>
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
The iteration should not assume every page has size of limit set (200) Signed-off-by: Aleksander Gondek <gondekaleksander@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1057 The iteration should not assume every page has size of limit set (200)
Checklist: