feat: Prevent EventBus with clients connected from being deleted #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Wang <whynowy@gmail.com>
whynowy
commented
Feb 11, 2021
| // | ||
| // It could also be used to check if the EventBus object can be safely deleted. | ||
| func Uninstall(ctx context.Context, eventBus *v1alpha1.EventBus, client client.Client, natsStreamingImage, natsMetricsImage string, logger *zap.SugaredLogger) error { | ||
| linkedEventSources, err := linkedEventSources(ctx, eventBus.Namespace, eventBus.Name, client) |
There was a problem hiding this comment.
Check if there's any EventSource or Sensor connected, if true, return an error, which will re-queue the request.
Signed-off-by: Derek Wang <whynowy@gmail.com>
Closed
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
…oproj#1066) * feat: Prevent EventBus with clients connected from being deleted Signed-off-by: Derek Wang <whynowy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Wang whynowy@gmail.com
Checklist: