Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(): making webhook secure #206

Merged
merged 2 commits into from Mar 6, 2019
Merged

feature(): making webhook secure #206

merged 2 commits into from Mar 6, 2019

Conversation

VaibhavPage
Copy link
Contributor

#72

@VaibhavPage VaibhavPage added the enhancement New feature or request label Mar 6, 2019
@VaibhavPage VaibhavPage added this to the v0.9 milestone Mar 6, 2019
magaldima
magaldima previously approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@magaldima magaldima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

magaldima
magaldima approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@magaldima magaldima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@VaibhavPage VaibhavPage merged commit d1c8120 into master Mar 6, 2019
@magaldima magaldima deleted the secure-webhook branch March 7, 2019 20:18
@ntwrkguru
Copy link 

  # make sure to create the secret with two keys- cert and private

Is this a standard kubernetes tls secret? Or just a normal secret with --from-file parameters?

juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
@VaibhavPage
feature(): making webhook secure (argoproj#206)
40d4ef4 
* feature(): making webhook secure

* chore(): updating secure webhook example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magaldima magaldima magaldima approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VaibhavPage @ntwrkguru @magaldima