docs: fix doc errors in managed namespace installation #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Wang <whynowy@gmail.com>
Signed-off-by: Derek Wang <whynowy@gmail.com>
Signed-off-by: Derek Wang <whynowy@gmail.com>
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| You can install `argo-events` in either cluster scoped or namespace scoped configuration, accordingly you need to set up ClusterRole or normal Role for service account `argo-events-sa`. | |||
|
|
|||
| In namespace scope installation, you must run `eventbus-controller`, `eventsource-controller` and `sensor-controller` with `--namespaced`. If you would like to have the controllers watching a separate namespace, add `--managed-namespace` as well. | |||
| In namespace scope installation, you must run `controller-manager` deployment with `--namespaced`. If you would like to have the controller watching a separate namespace, add `--managed-namespace` as well. | |||
There was a problem hiding this comment.
@whynowy maybe we should add some note for older versions (< v1.7) ?
daniel-codefresh
approved these changes
Aug 9, 2022
sarabala1979
approved these changes
Aug 9, 2022
daniel-codefresh
pushed a commit
to daniel-codefresh/argo-events
that referenced
this pull request
Aug 26, 2022
Signed-off-by: Derek Wang <whynowy@gmail.com> Signed-off-by: Daniel Soifer <daniel.soifer@codefresh.io>
whynowy
added a commit
that referenced
this pull request
Sep 10, 2022
Signed-off-by: Derek Wang <whynowy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: