Property name typo in Expr filter documentation #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In other examples on this page and all of the examples in examples/sensors the top level property of the Expr filter is `exprs`, not `expr`. This is the list of the filters, not the one with the details (that's correctly `expr`). The actual definition showing `exprs` appears to be here: https://github.com/argoproj/argo-events/blob/a9b5dd79c7341be999a526aacb77c87f7f7b3c08/pkg/apis/sensor/v1alpha1/generated.proto#L277 Here's some use in the examples showing `exprs` as opposed to `expr`. https://github.com/argoproj/argo-events/blob/b963de5607466a94bdc631d4f470d92913882178/examples/sensors/filter-with-multiple-filters.yaml#L25 Signed-off-by: Peter Hoellig <phoellig@gmail.com>
whynowy
pushed a commit
that referenced
this pull request
Dec 12, 2022
Signed-off-by: Peter Hoellig <phoellig@gmail.com>
bilalba
pushed a commit
to intuit-data-os/argo-events
that referenced
this pull request
Jan 9, 2023
Signed-off-by: Peter Hoellig <phoellig@gmail.com> Signed-off-by: Bilal Bakht Ahmad <tringingly@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In other examples on this page and all of the examples in examples/sensors the top level property of the Expr filter is
exprs, notexpr. This is the list of the filters, not the one with the details (that's correctlyexpr).The actual definition showing
exprsappears to be here:argo-events/pkg/apis/sensor/v1alpha1/generated.proto
Line 277 in a9b5dd7
Here's some use in the examples showing
exprsas opposed toexpr.argo-events/examples/sensors/filter-with-multiple-filters.yaml
Line 25 in b963de5
Checklist: