feat: update third_party dependencies #2245
Conversation
…nt version Signed-off-by: Jorge Machado <4804546+jomach@users.noreply.github.com> feat: update third_party dependency due to go security issue on current version Signed-off-by: Jorge Machado 4804546+jomach@users.noreply.github.com
jomach
force-pushed
the
feature/patchSecurityIssues
branch
from
18e6b25
to
a7c29b4
Compare
| @@ -5,4 +5,4 @@ This is a partial copy of | |||
| current | |||
| [nats-streaming-server](https://github.com/nats-io/nats-streaming-server) | |||
| version is | |||
| [v0.22.1](https://github.com/nats-io/nats-streaming-server/tree/v0.22.1). | |||
| [v0.25.2](https://github.com/nats-io/nats-streaming-server/releases/tag/v0.25.2). | |||
There was a problem hiding this comment.
Thanks for updating this, also please be aware these 3rd party related docs and Dockerfile are just references, in the real installation, the nats stream image is controlled by the controller configmap, where you can specify the image version.
There was a problem hiding this comment.
Yes, you are right. I saw that after creating the pr. Actually we could drop this third-party part right ? I saw in the helm chart we can pass in a nats container version. We are actually doing that and using now the latest version of nats-streaming-server
| ARG ARCH | ||
| RUN apk update && apk upgrade && \ | ||
| apk add ca-certificates && \ | ||
| apk --no-cache add tzdata | ||
|
|
||
| ENV ARGO_VERSION=v3.4.0 | ||
| ENV ARGO_VERSION=v3.4.1 |
|
@jomach - I'm also curious, what eventbus are you using? The new |
No idea to be honest. We have the newest chart 0.20. and we are using: |
Be aware Nat Streaming will be EoL by 2023, so we have a new EventBus implemented with |
|
@whynowy The Build failed. |
Transient network issue. |
Signed-off-by: Jorge Machado 4804546+jomach@users.noreply.github.com
Signed-off-by: Jorge Machado 4804546+jomach@users.noreply.github.com Signed-off-by: Bilal Bakht Ahmad <tringingly@gmail.com>
We use argo events with security scans. Our security scans shows that golang version is to old on the current version from nats container.