Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eventsource): Gitlab eventsource - support groups (#2386) #2474

Merged
merged 4 commits into from
Feb 23, 2023

Conversation

neo502721
Copy link
Contributor

Fix #2386. Support groups level hook to gitlab eventsource. This is available in Premium and Ultimate Gitlab.

Checklist:

eventsources/sources/gitlab/validate.go Outdated Show resolved Hide resolved
pkg/apis/eventsource/v1alpha1/types.go Show resolved Hide resolved
eventsources/sources/gitlab/start.go Outdated Show resolved Hide resolved
Signed-off-by: neo502721 <zgmhdu@163.com>
Signed-off-by: neo502721 <zgmhdu@163.com>
Signed-off-by: neo502721 <zgmhdu@163.com>
Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@whynowy whynowy merged commit 0564890 into argoproj:master Feb 23, 2023
@jwillker jwillker mentioned this pull request Mar 29, 2023
1 task
jwillker pushed a commit to jwillker/argo-events that referenced this pull request Mar 29, 2023
argoproj#2474)

Signed-off-by: neo502721 <zgmhdu@163.com>
Signed-off-by: JohnWillker <frazao.jhonn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gitlab eventsource support for groups
2 participants