fix: Reduce Sensor log verbosity for filtered events #2964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Compton <3343482+bencompton@users.noreply.github.com>
Signed-off-by: Ben Compton <3343482+bencompton@users.noreply.github.com>
bencompton
force-pushed
the
reduce-sensor-log-verbosity
branch
from
33ed9a3
to
26df34b
Compare
jmeridth
approved these changes
Jan 5, 2024
AmitMendl
pushed a commit
to AmitMendl/argo-events
that referenced
this pull request
Jan 13, 2024
Signed-off-by: AmitMendl <amit.mendelevitch@gmail.com>
ryancurrah
pushed a commit
to ryancurrah/argo-events
that referenced
this pull request
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing log level from
WARNtoDEBUGwhen events do not match a Sensor filter, as suggested by @whynowy in this issue comment. This represented ~400GB of logs per day in my cluster at scale, and logging the entire payload for discarded events is only useful for occasional debugging purposes.