feat: add waitTime config field to azure queue storage event source #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: eduardodbr <eduardodbr@hotmail.com>
|
CI failing because of #2993 |
whynowy
reviewed
Jan 27, 2024
Signed-off-by: eduardodbr <eduardodbr@hotmail.com>
5 tasks
whynowy
pushed a commit
that referenced
this pull request
Feb 13, 2024
…2996) Signed-off-by: eduardodbr <eduardodbr@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Azure queue storage eventsource is making the
DequeueMessageAPI call in a loop, which might create a lot of requests per second if the message queue is empty. Since the azure SDK does not allow for waiting for a message when the queue is empty like AWS SQS does, this PR adds a new config field that allow to configure how much time it should wait (sleep) between empty results from the queue. It defaults to 3 seconds.