Use authorized key parsing instead of reading binary certificates #3113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
The current implementation of the public key parsing a binary public key is needed (https://pkg.go.dev/golang.org/x/crypto/ssh#ParsePublicKey).
I would propose to switch to https://pkg.go.dev/golang.org/x/crypto/ssh#ParseAuthorizedKey as it supports a common string format, which is a lot easier to handle in secrets.
Example in go playground:
https://go.dev/play/p/doCqwWh6jpl