feat: enabling workflow identity for GKE #593
Conversation
chaseterry
changed the title
| # Empty credentials file when using Workflow Identity | ||
| credentialsFile: "" | ||
| # If enableWorkflowIdentity is true, the projects uses Workflow Identity for authentication | ||
| enableWorkflowIdentity: true |
There was a problem hiding this comment.
Can we do something like:
if len(credentialsFile) == 0 {
// consider it is using workload identity
} else {
//
}
There was a problem hiding this comment.
That would make it simpler, but I think it's helpful to include the enableWorkflowIdentity flag to inform users that Workflow Identity is an option
There was a problem hiding this comment.
I think informing the users that Workflow Identity is supported in the doc might be better than in the code.
There was a problem hiding this comment.
The tests will fail, this line https://github.com/argoproj/argo-events/blob/gke-workload-identity/gateways/server/gcp-pubsub/validate.go#L68 , you need to update validate method. Make sure to run make test.
| @@ -65,8 +66,5 @@ func validate(eventSource *v1alpha1.PubSubEventSource) error { | |||
| if eventSource.Topic == "" { | |||
| return fmt.Errorf("must specify topic") | |||
| } | |||
There was a problem hiding this comment.
You want to check if the EnableWorkloadIdentity is set to true, if so, then its fine to not have credentialsFile else it is required to have the credentialsFile.
* enabling workflow identity for GKE * Updated gcp-pubsub-workflow-identity.yaml to remove unneccesary double quotes * updating gcp-pubsub-workflow-identity.yaml * removed extra pubsub client * updated gcp pubsub validate * update gcp pubsub validate * condense gcp pubsub examples
Added enableWorkflowIdentity flag to PubSubEventSource.
Added Workflow Identity toggle in gcp-pubsub gateway based on enableWorkflowIdentity flag.
Closing #503