Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert CRD apiVersion #625

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Conversation

tumido
Copy link
Contributor

@tumido tumido commented Apr 27, 2020

I was a bit reckless when upgrading CRD from v1beta1 to v1 in #607. I did two mistakes:

  1. Simple versions (version) are no longer available, only the long form versions is supported
  2. A schema field is a required in v1. That means, even enforcing v1 api with an empty spec like this:
    schema:
      openAPIV3Schema:
        type: object
    
    would require users to create every object with --validate=false flag for now, and I don't think that's what we want.

Let's revert back to v1beta1.

Also.. fixing a typo s/cdrs/crds/g and making event-source CRD name consistent with pkg/apis/eventsources/

I've tried implementing the OpenAPIV3Schema in another PR #624, but I'm not much successful with that so far... Let's discuss that option there.

Copy link

@nfp007 nfp007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to apply issue is fixed by this PR

@VaibhavPage VaibhavPage merged commit 6295610 into argoproj:master Apr 27, 2020
juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants