Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was a bit reckless when upgrading CRD from
v1beta1
tov1
in #607. I did two mistakes:version
) are no longer available, only the long formversions
is supportedschema
field is a required inv1
. That means, even enforcingv1
api with an empty spec like this:--validate=false
flag for now, and I don't think that's what we want.Let's revert back to
v1beta1
.Also.. fixing a typo
s/cdrs/crds/g
and makingevent-source
CRD name consistent withpkg/apis/eventsources/
I've tried implementing the OpenAPIV3Schema in another PR #624, but I'm not much successful with that so far... Let's discuss that option there.