Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Expose metadata for sensors and fix metadata for eventsources #773

Merged
merged 1 commit into from Jul 26, 2020
Merged

feat: Expose metadata for sensors and fix metadata for eventsources #773

merged 1 commit into from Jul 26, 2020

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Jul 26, 2020

  1. Fixed metadata for eventsource deployment - somehow it was missing in previous PR.
  2. Added metadata support for Sensor
spec:
  template:
    metadata:
      labels:
        a: b
      annotations:
        c: d
  1. Removed unused serviceAccountName from some of the event source examples and sensor examples.

@whynowy whynowy requested a review from VaibhavPage July 26, 2020 00:54
@VaibhavPage VaibhavPage merged commit 21f4360 into argoproj:master Jul 26, 2020
@whynowy whynowy deleted the example_fix branch July 26, 2020 17:47
@whynowy whynowy mentioned this pull request Jul 28, 2020
Merged
juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
@whynowy
feat: Expose metadata for sensors and fix metadata for eventsources (a…
3887f59 
…rgoproj#773)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VaibhavPage VaibhavPage VaibhavPage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@whynowy @VaibhavPage