Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflow-trigger): Add labels to created k8s objects. Fixes #794 #805

Merged
merged 4 commits into from Aug 4, 2020

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Aug 4, 2020

Fixes #794

Added labels to all the created k8s objects including workflow

events.argoproj.io/sensor: sensor-name
events.argoproj.io/trigger: trigger-name
events.argoproj.io/action-timestamp: timestamp

@whynowy whynowy marked this pull request as ready for review August 4, 2020 17:18
@whynowy whynowy changed the title fix(workflow-trigger): Use list api to get created workflow fix(workflow-trigger): Add labels to created k8s objects Aug 4, 2020
@whynowy whynowy changed the title fix(workflow-trigger): Add labels to created k8s objects fix(workflow-trigger): Add labels to created k8s objects. Fixes #794 Aug 4, 2020
Copy link
Contributor

@VaibhavPage VaibhavPage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

@whynowy whynowy merged commit 12ae7b2 into argoproj:master Aug 4, 2020
@whynowy whynowy deleted the issue-794 branch August 4, 2020 18:18
juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple ArgoWorkflow Trigger error
2 participants