feat: Simplify TLS config for EventSources and Sensors. Closes #828 #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whynowy
added a commit
that referenced
this pull request
Aug 20, 2020
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
…oj#828 (argoproj#830) * feat: Simplify TLS config for EventSources and Sensors * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including following changes:
TLSConfigin event source is updated to usesecretKeySelector,xxxxPathis deprecated, as a result, event sources usingTLSConfighave spec changes with backward compatibility -amqp,kafka,mqtt,nats,emitter,Pulsar,redisandnsq.ServerCertPathandServerKeyPathinWebhookContextare changed to usesecretKeySelectorwith backward compatibility, thus event sources using it have spec changes -webhook,github,gitlab,sns,slack,Storage GRIDandstripe.TLSConfigin sensor is also changed to usesecretKeySelectorwith backward compatibility, sohttp,natsandkafkatriggers have spec changes.CertFilePathinCustomTriggeris changed to usesecretKeySelector, new field name isCertSecret.SSHKeyPathinSlackTriggeris changed to usesecretKeySelector, new field name isSSHKeySecret.TLSTrustCertsFilePathinPulsarEventSourceis changed to usesecretKeySelector, new field name isTLSTrustCertsSecret.For the changes above, there's no need to mount the secrets as volumes to the POD.
Closes #828