feat(argo-cd): Add scrapeTimeout property to server and application… #2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolay-o
requested review from
mbevc1,
mkilchhofer,
yu-croco,
jmeridth,
pdrastil and
tico24
as code owners
nikolay-o
force-pushed
the
feature/scrapeTimeout
branch
from
6c39fe5
to
21b22f2
Compare
nikolay-o
changed the title
nikolay-o
force-pushed
the
feature/scrapeTimeout
branch
from
21b22f2
to
a75edd9
Compare
nikolay-o
changed the title
nikolay-o
force-pushed
the
feature/scrapeTimeout
branch
2 times, most recently
from
bbea04c
to
cb277a0
Compare
yu-croco
reviewed
Feb 10, 2024
charts/argo-cd/Chart.yaml
Outdated
Comment on lines
29
to
30
| - kind: changed | ||
| description: Improved documentation for various ingress setups |
There was a problem hiding this comment.
Fixed, thanks for review
nikolay-o
force-pushed
the
feature/scrapeTimeout
branch
from
cb277a0
to
f10e44a
Compare
yu-croco
reviewed
Feb 10, 2024
charts/argo-cd/templates/argocd-application-controller/servicemonitor.yaml
Outdated
Show resolved
Hide resolved
mkilchhofer
requested changes
Feb 10, 2024
nikolay-o
force-pushed
the
feature/scrapeTimeout
branch
from
f10e44a
to
0bda234
Compare
nikolay-o
force-pushed
the
feature/scrapeTimeout
branch
2 times, most recently
from
d87181d
to
261686f
Compare
|
@mkilchhofer I fixed documentation, could you please look? |
nikolay-o
force-pushed
the
feature/scrapeTimeout
branch
from
261686f
to
534c4a1
Compare
…applicationset controllers. Signed-off-by: Nikolay Osmolovskiy <nikolay.osmolovsky@gmail.com>
nikolay-o
force-pushed
the
feature/scrapeTimeout
branch
from
534c4a1
to
8f1d671
Compare
mkilchhofer
approved these changes
Feb 12, 2024
Perfect, thank you so much for your contribution. |
mbevc1
approved these changes
Feb 12, 2024
pdrastil
added a commit
to pdrastil/argo-helm
that referenced
this pull request
Feb 13, 2024
* main: feat(argo-cd): Add scrapeTimeout property to server and application… (argoproj#2489)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added scrapeTimeout property to server and application, applicationSet controllers.