fix(argocd-image-updater): Properly quoting the config map values (and other fixes) #2512
+27
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqeelat
requested review from
mkilchhofer,
jmeridth and
yu-croco
as code owners
aqeelat
force-pushed
the
improve-helm-chart
branch
from
3d6a35c
to
2677855
Compare
mkilchhofer
approved these changes
Feb 29, 2024
|
Hi @aqeelat , thank you for your PR. |
fix(argocd-image-updater): Only adding a data field to argocd-image-updater-ssh-config when there's data to be added fix(argocd-image-updater): Only include config.argocd if config.applicationsAPIKind is set to 'argocd' chore(argocd-image-updater): removing unneeded whitespace in Role and RoleBinding Signed-off-by: Abdullah Alaqeel <a.alaqeel@sary.com>
aqeelat
force-pushed
the
improve-helm-chart
branch
from
500b6fc
to
c8b4b06
Compare
|
@yu-croco done |
yu-croco
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(argocd-image-updater): Properly quoting the config map values
fix(argocd-image-updater): Only adding a data field to argocd-image-updater-ssh-config when there's data to be added
fix(argocd-image-updater): Only include config.argocd if config.applicationsAPIKind is set to 'argocd'
chore(argocd-image-updater): removing unneeded whitespace in Role and RoleBinding
Checklist: