Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(argo-cd): Allow to use dedicated gRCP ingress with GKE implementation #2541

Merged
merged 1 commit into from Feb 23, 2024
Merged

fix(argo-cd): Allow to use dedicated gRCP ingress with GKE implementation #2541

merged 1 commit into from Feb 23, 2024

Conversation

pdrastil
Copy link
Member

Resolves: #2540

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@pdrastil pdrastil changed the title fix(argo-cd): Allow to use dedicated grpc with GKE implementation fix(argo-cd): Allow to use dedicated grpc ingress with GKE implementation Feb 22, 2024
@pdrastil pdrastil changed the title fix(argo-cd): Allow to use dedicated grpc ingress with GKE implementation fix(argo-cd): Allow to use dedicated gRCP ingress with GKE implementation Feb 22, 2024
@pdrastil
fix(argo-cd): Allow to use dedicated grpc with GKE implementation
415bdc0 
Signed-off-by: Petr Drastil <petr.drastil@gmail.com>
@mkilchhofer mkilchhofer merged commit 2f91378 into argoproj:main Feb 23, 2024
6 checks passed
@pdrastil pdrastil deleted the fix/grpc branch February 23, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacek-jablonski jacek-jablonski jacek-jablonski left review comments

@mkilchhofer mkilchhofer mkilchhofer approved these changes

@mbevc1 mbevc1 mbevc1 approved these changes

@yu-croco yu-croco Awaiting requested review from yu-croco yu-croco is a code owner

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@tico24 tico24 Awaiting requested review from tico24 tico24 is a code owner

Assignees
No one assigned
Labels
argo-cd size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Argo CD] ingressGrpc shouldn't depend on ingress' controller field
4 participants
@pdrastil @mkilchhofer @mbevc1 @jacek-jablonski