-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(argocd-image-updater): Add ability to set .Values.namespaceOverride #2562
feat(argocd-image-updater): Add ability to set .Values.namespaceOverride #2562
Conversation
46d79a2
to
b349e67
Compare
Signed-off-by: Braden Wright <braden.wright@waltlabs.io>
b349e67
to
3acec1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really dislike the approach when charts install resources in namespaces outside the helm install --namespace xyz
parameter.
Can you elaborate your use case a bit better? Do you use an umbrella chart which installs charts into multiple namespaces?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did some research if there are charts in the world which supports exactly this behavior and I found a bunch:
- kubernetes/ingress-nginx
- metacontroller/metacontroller
- Some charts from Bitnami: https://github.com/search?q=repo%3Abitnami%2Fcharts%20namespaceOverride&type=code
I accept your PR now, thanks for your contribution 😎
I use this chart as a dependency but the .Release.Namespace is
bootstrap
, but I need to install argocd-image-updater chart intoargo
namespace. This allows that and makes everything fall into place for me.Checklist: