Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(argocd-image-updater): Add ability to set .Values.namespaceOverride #2562

Conversation

bradenwright
Copy link
Contributor

@bradenwright bradenwright commented Mar 1, 2024

I use this chart as a dependency but the .Release.Namespace is bootstrap, but I need to install argocd-image-updater chart into argo namespace. This allows that and makes everything fall into place for me.


Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@bradenwright bradenwright force-pushed the namespaceOverride-for-argocd-image-updater branch 2 times, most recently from 46d79a2 to b349e67 Compare March 1, 2024 04:48
@bradenwright bradenwright changed the title added ability to set .Values.namespace override feat: added ability to set .Values.namespace override Mar 1, 2024
@bradenwright bradenwright changed the title feat: added ability to set .Values.namespace override feat(argocd-image-updater): added ability to set .Values.namespace override Mar 1, 2024
Signed-off-by: Braden Wright <braden.wright@waltlabs.io>
@bradenwright bradenwright force-pushed the namespaceOverride-for-argocd-image-updater branch from b349e67 to 3acec1c Compare March 1, 2024 05:25
Copy link
Member

@mkilchhofer mkilchhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really dislike the approach when charts install resources in namespaces outside the helm install --namespace xyz parameter.

Can you elaborate your use case a bit better? Do you use an umbrella chart which installs charts into multiple namespaces?

Copy link
Member

@mkilchhofer mkilchhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some research if there are charts in the world which supports exactly this behavior and I found a bunch:

I accept your PR now, thanks for your contribution 😎

@mkilchhofer mkilchhofer changed the title feat(argocd-image-updater): added ability to set .Values.namespace override feat(argocd-image-updater): Add ability to set .Values.namespaceOverride Mar 1, 2024
@mkilchhofer mkilchhofer merged commit fba54d4 into argoproj:main Mar 1, 2024
10 checks passed
@bradenwright bradenwright deleted the namespaceOverride-for-argocd-image-updater branch March 7, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants