New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(argo-cd): enabled server cluster role permissions overriding #2606
Merged
mkilchhofer
merged 8 commits into
argoproj:main
from
edmondshtogu:argo-cd-server-cr-roles
Apr 2, 2024
Merged
feat(argo-cd): enabled server cluster role permissions overriding #2606
mkilchhofer
merged 8 commits into
argoproj:main
from
edmondshtogu:argo-cd-server-cr-roles
Apr 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: edmondshtogu <edmondshtogu@gmail.com>
Signed-off-by: edmondshtogu <edmondshtogu@gmail.com>
Signed-off-by: edmondshtogu <edmondshtogu@gmail.com>
Signed-off-by: edmondshtogu <edmondshtogu@gmail.com>
edmondshtogu
requested review from
mbevc1,
mkilchhofer,
yu-croco,
jmeridth,
pdrastil and
tico24
as code owners
March 25, 2024 22:31
edmondshtogu
changed the title
enhancement: Support for Overriding Argo CD Server ClusterRole Permissions
feat(argo-cd): enabled server cluster role permissions overriding
Mar 25, 2024
Signed-off-by: edmondshtogu <edmondshtogu@gmail.com>
Signed-off-by: edmondshtogu <edmondshtogu@gmail.com>
yu-croco
reviewed
Mar 26, 2024
Signed-off-by: edmondshtogu <edmondshtogu@gmail.com>
Hi team, can someone please review and unblock this PR so we can merge the enhancement if there is no further change required? |
yu-croco
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. LGTM.
mkilchhofer
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2605
Checklist: