Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(argo-cd): Properly support "application in any namespace" for the argocd-server ClusterRole #2609

Merged
merged 4 commits into from Mar 29, 2024
Merged

fix(argo-cd): Properly support "application in any namespace" for the argocd-server ClusterRole #2609

merged 4 commits into from Mar 29, 2024

Conversation

GuillaumeRemyCSI
Copy link
Contributor

@GuillaumeRemyCSI GuillaumeRemyCSI commented Mar 28, 2024 •
edited by mbevc1

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@GuillaumeRemyCSI GuillaumeRemyCSI changed the title Properly support "application in any namespace" for the argocd-server ClusterRole Fix: properly support "application in any namespace" for the argocd-server ClusterRole Mar 28, 2024
@GuillaumeRemyCSI GuillaumeRemyCSI changed the title Fix: properly support "application in any namespace" for the argocd-server ClusterRole fix(argo-cd): Properly support "application in any namespace" for the argocd-server ClusterRole Mar 28, 2024
pdrastil
pdrastil approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@pdrastil pdrastil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Upstream: https://github.com/argoproj/argo-cd/tree/master/examples/k8s-rbac/argocd-server-applications

@GuillaumeRemyCSI
Copy link
Contributor Author

LGTM Upstream: https://github.com/argoproj/argo-cd/tree/master/examples/k8s-rbac/argocd-server-applications

I also changed the notification controller ClusterRole to properly handle self-managed notifications in the context of "application in any namespace"

@GuillaumeRemyCSI
Properly support "application in any namespace" for the argocd-server…
5117a6f 
… ClusterRole

Signed-off-by: GuillaumeRemyCSI <30650458+GuillaumeRemyCSI@users.noreply.github.com>
@GuillaumeRemyCSI
Add changelog
b53f4f8 
Signed-off-by: GuillaumeRemyCSI <30650458+GuillaumeRemyCSI@users.noreply.github.com>
@GuillaumeRemyCSI
notification controller can handle self-managed notification in any n…
1cb104f 
…amespace

Signed-off-by: GuillaumeRemyCSI <30650458+GuillaumeRemyCSI@users.noreply.github.com>
@GuillaumeRemyCSI
Bump argo-cd chart to v6.7.5
b14378a 
Signed-off-by: GuillaumeRemyCSI <30650458+GuillaumeRemyCSI@users.noreply.github.com>
@yu-croco yu-croco merged commit e9a3381 into argoproj:main Mar 29, 2024
6 checks passed
@GuillaumeRemyCSI GuillaumeRemyCSI deleted the patch-1 branch March 29, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdrastil pdrastil pdrastil approved these changes

@mbevc1 mbevc1 mbevc1 approved these changes

@yu-croco yu-croco yu-croco approved these changes

@mkilchhofer mkilchhofer Awaiting requested review from mkilchhofer mkilchhofer is a code owner

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@tico24 tico24 Awaiting requested review from tico24 tico24 is a code owner

Assignees
No one assigned
Labels
argo-cd size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GuillaumeRemyCSI @pdrastil @mbevc1 @yu-croco