Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(argo-cd): Pre-set statusbadge.url value to global.domain #2657

Merged
merged 1 commit into from Apr 21, 2024
Merged

feat(argo-cd): Pre-set statusbadge.url value to global.domain #2657

merged 1 commit into from Apr 21, 2024

Conversation

bojanraic
Copy link
Contributor

Closes #2656

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@bojanraic
feat(argo-cd): Pre-set statusbadge.url value to global.domain
704c4cd 
Signed-off-by: Bojan Raic <code@bojan.io>
mkilchhofer
mkilchhofer approved these changes Apr 21, 2024
View reviewed changes
Copy link
Member

@mkilchhofer mkilchhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mkilchhofer mkilchhofer merged commit 7ad09a9 into argoproj:main Apr 21, 2024
6 checks passed
@bojanraic bojanraic deleted the feat/preset-statusbadge-url branch April 21, 2024 23:41
@mkilchhofer mkilchhofer mentioned this pull request Apr 23, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkilchhofer mkilchhofer mkilchhofer approved these changes

@yu-croco yu-croco yu-croco approved these changes

@tico24 tico24 tico24 approved these changes

@mbevc1 mbevc1 Awaiting requested review from mbevc1 mbevc1 is a code owner

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@pdrastil pdrastil Awaiting requested review from pdrastil pdrastil is a code owner

Assignees
No one assigned
Labels
argo-cd size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ArgoCD CM: Pre-populate the statusbadge.url value with value of global.domain
4 participants
@bojanraic @mkilchhofer @yu-croco @tico24