fix(argo-cd): Enable Redis authentication in the default installation #2705
Conversation
* fix: Implement redis authentication Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com> chore: Rework as a Kubernetes Job (use ingress-nginx/cert-manager approach) Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com> fix: Implement redis probes (add auth) Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com> feat: Add some standardization on the newly added resources Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com> fix: Ensure externalRedis is still working properly Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com> fix: Use correct ServiceAccount in Job Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com> * docs: Add note about secret rotation, bump chart version Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com> * chore: Use final appVersion from upstream Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com> --------- Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
mkilchhofer
requested review from
mbevc1,
yu-croco,
jmeridth,
pdrastil and
tico24
as code owners
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
mkilchhofer
force-pushed
the
bugfix/argo-cd_redis_auth
branch
from
bc5d54d
to
975247c
Compare
|
@mkilchhofer seems your signing GPG expired? |
Should not block the PR here :D Issue is my new mail addy due to my new last name |
|
Hi, May I ask if this will be backported to 6.7.x (chart supporting Argo CD 2.10.x)? |
|
Hi @nbarrientos , argo-helm/charts/argo-cd/values.yaml Line 59 in f431e9b |
|
Thanks. Do versions of the Helm chart newer than 6.7.x (e.x. 6.10.0) support Argo CD v2.10.x? For instance since this commit they might not but it's not clear to me what's the lower bound of supported Argo CD versions when you bump |
|
@yu-croco |
|
Oh I see... 😭 |
Shall I open an issue to discuss this further? |
Yes that would be more intuitive than discussing on a closed PR. |
See GHSA as soon as it's published:
GHSA-9766-5277-j5hr