Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix analysis information box #2530

Closed
2 tasks done
Hronom opened this issue Jan 23, 2023 · 0 comments · Fixed by #2575
Closed
2 tasks done

Fix analysis information box #2530

Hronom opened this issue Jan 23, 2023 · 0 comments · Fixed by #2575
Labels
bug Something isn't working

Comments

@Hronom
Copy link

Hronom commented Jan 23, 2023 •
edited
Loading

Checklist:

  • I've included steps to reproduce the bug.
  • I've inclued the version of argo rollouts.

Describe the bug

There information button that you can click and check what setings for analysis was set.
However, when you click it - popup message messed with icons from Steps frame (check screenshot).

To Reproduce

Expected behavior

Screenshots

image

Version

v1.4.0+e40c9fe

Logs

# Paste the logs from the rollout controller

# Logs for the entire controller:
kubectl logs -n argo-rollouts deployment/argo-rollouts

# Logs for a specific rollout:
kubectl logs -n argo-rollouts deployment/argo-rollouts | grep rollout=<ROLLOUTNAME

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.
@Hronom Hronom added the bug Something isn't working label Jan 23, 2023
@zachaller zachaller mentioned this issue Feb 8, 2023
Merged
6 tasks
zachaller added a commit that referenced this issue Feb 8, 2023
@schakrad @alexmt @zachaller
fix: analysis information box #2530 (#2575)
6fccbe6 
* fix: add workaround to fix 'stream terminated by RST_STREAM with error code: PROTOCOL_ERROR'

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* Analysis info tooltip overlapping over step content

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>

---------

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>
Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Co-authored-by: zachaller <zachaller@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: analysis information box #2530 schakrad/argo-rollouts
1 participant
@Hronom